Feat/bb api helper functions #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Jan 15, 2024
imessage/bluebubbles/api.go
Outdated
| for _, chat := range *response.Data { | ||
| resp = append(resp, imessage.ChatIdentifier{ | ||
| ChatGUID: fmt.Sprintf("%v", chat.GUID), | ||
| ThreadID: fmt.Sprintf("%v", chat.ChatIdentifier), // TODO Is this the right one to use? |
There was a problem hiding this comment.
The thread ID field is for iMessage group IDs, which are usually uuids. Not sure if BlueBubbles exposes them anywhere, but it's fine to just omit the field
There was a problem hiding this comment.
Also, fmt.Sprintfing a string to get the same string seems kind of pointless
imessage/bluebubbles/interface.go
Outdated
| type ChatQueryResponse struct { | ||
| Status int64 `json:"status"` | ||
| Message string `json:"message"` | ||
| Data *[]Chat `json:"data"` |
There was a problem hiding this comment.
This probably doesn't need to be a pointer, slices are nillable on their own
imessage/bluebubbles/api.go
Outdated
Comment on lines
320
to
323
| "lastMessage", | ||
| "sms", | ||
| }, | ||
| Sort: "lastmessage", |
There was a problem hiding this comment.
These would probably be good to extract into constants
tulir
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper functions to build the URL and make GetChatsWithMessagesAfter work in a very light fashion