Skip to content

handle*: add basic support for thread read receipts - #123

Open
tulir wants to merge 3 commits into
mainfrom
tulir/thread-read-receipts
Open

tulir wants to merge 3 commits into
mainfrom
tulir/thread-read-receipts

Conversation

@tulir

@tulir tulir commented Oct 19, 2026

Copy link
Copy Markdown
Member

No description provided.

@indent

indent Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Issues

All clear! No issues remaining. 🎉

3 issues already resolved
  • A Matrix read receipt whose thread_id isn't in the message DB makes GetPartByMXID return (nil, nil), and threadMsg.ID then panics. The receipt is dropped and a panic error status is emitted. Check for nil before parsing the ID. (fixed by commit db0b2ca)
    Found by Indent Review Agent
  • Empty LastRead is now skipped, but if LastRead is set and not in the bridge DB, bridgev2 falls back to the newest room-wide message at EventTimestamp (roughly now). The receipt then targets an unrelated main-timeline message. Use LastRead for the timestamp, or skip the time fallback for receipts with a thread root. (fixed by commit 1a70103)
    Found by Indent Review Agent
  • SlackReadReceipt implements GetReceiptThread for every receipt. For channel/IM/group marks ThreadRoot is empty, so bridgev2 does a GetLastPartByID lookup with an empty ID and logs "Thread root message not found" on each receipt. Use a separate thread-receipt wrapper type. (fixed by commit 1a70103)
    Found by Indent Review Agent

CI Checks

All required CI checks passed on 1a70103.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · Both open findings are fixed in the pinned mautrix-go; no remaining issues.
Full results

Indent Review Agent

  • Summary: Both open findings are fixed in the pinned mautrix-go; no remaining issues.
  • Last ran on commit: 1a701036
  • Latest result
    {
      "summary": "Both open findings are fixed in the pinned mautrix-go; no remaining issues.",
      "findings": []
    }

Comment thread pkg/connector/handlematrix.go Outdated
Comment thread pkg/connector/handleslack.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant