-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rtsp static rtsp sink #213
Fix rtsp static rtsp sink #213
Conversation
@@ -26,8 +27,11 @@ impl PipelineRunner { | |||
let pipeline_weak = pipeline.downgrade(); | |||
let (killswitch_sender, _killswitch_receiver) = broadcast::channel(1); | |||
let watcher_killswitch_receiver = killswitch_sender.subscribe(); | |||
let (start_signal_sender, start_signal_receiver) = broadcast::channel(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to point out that while solutions using the oneshot
channel or barrier
would have solved it, the broadcast
channel is the easiest to deal with without fighting with async.
@joaoantoniocardoso please create the release and prepare it to BlueOS, I would like to create a new version with it ASAP. |
Hello, |
Hi @aihamshikhomicro, I moved it to a new issue, I'll respond to you there: #269 |
Fixes #210 by connecting sinks before starting the pipeline.
Don't merge it yet as I'm still testing all cases.
Tests: