Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtsp static rtsp sink #213

Merged

Conversation

joaoantoniocardoso
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso commented Apr 19, 2023

Fixes #210 by connecting sinks before starting the pipeline.

Don't merge it yet as I'm still testing all cases.

Tests:

  • RTSP h264 1080p 30fps + with multiple WebRTC clients
  • UDP h264 1080p 30fps + with multiple WebRTC clients
  • stress streams creation
  • stress thumbnails
  • RTSP with other encodings, sizes and fpss
  • UDP with other encodings, sizes and fpss

@@ -26,8 +27,11 @@ impl PipelineRunner {
let pipeline_weak = pipeline.downgrade();
let (killswitch_sender, _killswitch_receiver) = broadcast::channel(1);
let watcher_killswitch_receiver = killswitch_sender.subscribe();
let (start_signal_sender, start_signal_receiver) = broadcast::channel(1);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to point out that while solutions using the oneshot channel or barrier would have solved it, the broadcast channel is the easiest to deal with without fighting with async.

@patrickelectric patrickelectric merged commit c0bd65b into mavlink:master Apr 19, 2023
@patrickelectric
Copy link
Member

@joaoantoniocardoso please create the release and prepare it to BlueOS, I would like to create a new version with it ASAP.

@aihamshikhomicro
Copy link

Hello,
I don't know if this is the right place to ask my question but it's not an actual issue so I'll ask it here.
How do I create a redirect stream from a rtsp IP camera stream?
I created a gstreamer pipline to receive it and it's working fine, but how do I create a MAVLINK stream from it? the device in the UI for redirect source is a fixed text, where do I specify my rtsp link an create a redirect out of it?

@joaoantoniocardoso
Copy link
Collaborator Author

joaoantoniocardoso commented Aug 17, 2023

Hi @aihamshikhomicro, I moved it to a new issue, I'll respond to you there: #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTSP is broken in t3.11.0 for Raspberry Pi
3 participants