Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed creation of MavConnection implementations #293

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Typed creation of MavConnection implementations #293

merged 2 commits into from
Jan 9, 2025

Conversation

pv42
Copy link
Contributor

@pv42 pv42 commented Jan 5, 2025

See #290

Adds

  • connection address data structs: UdpConnectable, SerialConnectable, TcpConnectable and FileConnectable
  • pub enum ConnectionAddress representing a parsed address string with ::parse_address(&str) -> Self constructor and impl Display
  • pub traits AsyncConnectable, Connectable providing the connect[_async]() functions enabled with the tokio-1 and std features
  • parse_test test to validate ConnectionAddress's parse/fmt functions

Fixes:

  • supress unused_variables warning when compiled without signing feature

@patrickelectric patrickelectric merged commit a44abd2 into mavlink:master Jan 9, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pv42 @patrickelectric