Fix for #1016 #1017
Open
Fix for #1016 #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue maxence-charriere#1016
pkg/app/gen/html.go:2448:4: fmt.Fprintf format %s reads arg maxence-charriere#1, but call has 0 args pkg/app/gen/html.go:2584:5: fmt.Fprintln call has possible Printf formatting directive %v pkg/app/gen/html.go:2610:5: fmt.Fprintln call has possible Printf formatting directive %v pkg/app/gen/html.go:2631:4: fmt.Fprintln call has possible Printf formatting directive %s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit corrects the broken call to
e.Style().The second commit addresses subsequently revealed
go veterrors due to format verbs in the Go code printed byFprintlncalls (numerous StackOverflow discussions over the years about false positives in this area).