Skip to content

Build release binaries for PHP 8.6 - #26

Merged
ugexe merged 1 commit into
mainfrom
greg/stf-2474-test-the-php-api-clients-on-php-86
Nov 20, 2026
Merged

ugexe merged 1 commit into
mainfrom
greg/stf-2474-test-the-php-api-clients-on-php-86

Conversation

@oschwald

@oschwald oschwald commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

PHP 8.6.0 was released on 19 Nov 2026. This adds PHP 8.6 to the release binaries.

docker-library publishes PHP 8.6 images as ZTS only (docker-library/php#1686). php:8.6-cli-bookworm is a ZTS build, and no 8.6 NTS image exists. So:

  • Linux 8.6 ZTS builds in php:8.6-cli-bookworm, pinned by digest.
  • Linux 8.6 NTS is skipped. setup emits a linux-exclude list, the Linux matrix excludes those legs, and collect-assets.sh subtracts them from the expected asset count. PIE builds Linux 8.6 NTS from source.
  • macOS and Windows build 8.6 in both TS modes.

The reduced pull-request matrix moves from 8.2 and 8.5 to 8.2 and 8.6, so it still builds the ends of the range. The source-build job moves to the 8.6 image, so it still uses a version the reduced matrix builds.

ENG-5854 tracks adding Linux 8.6 NTS if docker-library brings NTS back (docker-library/php#1719).

STF-2474

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features

  • Release builds now support PHP 8.6, including Linux ZTS builds. PHP 8.6 Linux NTS builds are not included because a compatible build image is unavailable.
  • Release packaging checks now account for the available PHP 8.6 build combinations across Linux and macOS, helping ensure release assets are checked against the supported build matrix.

docker-library publishes PHP 8.6 as ZTS only, so no image exists for
Linux 8.6 NTS. Skip that leg with a new linux-exclude list from setup.
collect-assets.sh subtracts the skipped legs from the expected count.
PIE builds Linux 8.6 NTS from source.

The reduced pull-request matrix moves from 8.2 and 8.5 to 8.2 and 8.6,
so it still builds the ends of the range. The source-build job moves to
the 8.6 image for the same reason.

STF-2474

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oschwald
oschwald requested review from horgh and a balanced review from Copilot November 20, 2026 15:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release workflow adds PHP 8.6 to selected builds. It excludes the Linux NTS build and passes that exclusion to asset verification and collection. The asset-count script subtracts excluded Linux combinations while retaining the macOS count.

Changes: PHP 8.6 release support

Layer / File(s) Summary
PHP matrix and Linux exclusions
.github/workflows/release.yml
The setup job adds PHP 8.6 and filters the Linux NTS exclusion against the active PHP matrix. The Linux matrix receives the filtered exclusion.
PHP 8.6 build images
.github/workflows/release.yml
The source-build job and Linux ZTS image selector use the PHP 8.6 CLI Bookworm image.
Asset exclusion counting
.github/workflows/release.yml, dev-bin/collect-assets.sh
Asset verification and collection receive the Linux exclusion list. The asset-count script subtracts excluded Linux PHP and TS combinations before multiplying by the architecture count; the macOS count remains unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: Minimal · up to 927a8

This change adds PHP 8.6 to the release builds, skips the Linux NTS build because upstream images are ZTS-only, and adjusts the expected asset count to match. No actionable merge-blocking risk was found. The workflow still runs only at release time, so normal release-time validation applies.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Build release binaries for PHP 8.6" matches the main change. The PR adds PHP 8.6 to the release-binary matrix, including Linux 8.6 ZTS, macOS and Windows builds in both TS modes, and the so…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Build release binaries for PHP 8.6" matches the main change. The PR adds PHP 8.6 to the release-binary matrix, including Linux 8.6 ZTS, macOS and Windows builds in both TS modes, and the source-build image. The title does not mention the Linux NTS exclusion or the reduced pull-request matrix, but those are secondary details.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the release trail,
PHP eight-six joins the queue.
The Linux NTS path steps aside,
While asset counts adjust in view.
The rabbit hops; the builds proceed.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 27a4f0ca-aa00-4a4d-8968-753f07c3036f
Commits

Reviewing files that changed from the base of the PR and between 8d98c6c and 927a89d.

Files selected for processing: 2

  • .github/workflows/release.yml
  • dev-bin/collect-assets.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@smirnov-e

Copy link
Copy Markdown

@oschwald Keep in mind that these change (dropping NTS builds) can be considered supply chain attack done by FrankenPHP.

@oschwald

Copy link
Copy Markdown
Member Author

@smirnov-e I am sorry; I don't understand the comment. We are not dropping anything. We are not adding the NTS builds for 8.6 as they aren't available for the images we are using. If NTS images are added, we will add builds for them. You are free to build from the source as well.

@ugexe
ugexe merged commit 37daee9 into main Nov 20, 2026
32 checks passed
@ugexe
ugexe deleted the greg/stf-2474-test-the-php-api-clients-on-php-86 branch November 20, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants