Skip to content

STF-2368: Update mmdbwriter to the latest main commit - #150

Merged
mm-kevcenteno merged 1 commit into
mainfrom
greg/stf-2368-mmdbwriter-pseudo
Nov 14, 2026
Merged

mm-kevcenteno merged 1 commit into
mainfrom
greg/stf-2368-mmdbwriter-pseudo

Conversation

@oschwald

@oschwald oschwald commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Check Untagged Dependencies fails on main. It fails when a newer commit exists for a pseudo-versioned dependency. This moves mmdbwriter from 34b590caf65a to 94d3a330ab9c, the current mmdbwriter main.

The new mmdbwriter commits contain only CI updates. go test ./... and go vet ./... pass.

The check fails again when mmdbwriter main moves. Tagging mmdbwriter v2 removes the pseudo-version. maxmind/MaxMind-DB#318 makes the same change.

STF-2368

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to a newer version.

Check Untagged Dependencies fails when a newer commit exists for a
pseudo-versioned dependency. The new mmdbwriter commits contain only CI
updates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 13, 2026 20:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

go.mod updates the required version of github.com/maxmind/mmdbwriter/v2 from v2.0.0-20261026204648-34b590caf65a to v2.0.0-20261103192512-94d3a330ab9c.

Changes: Dependency version update

Layer / File(s) Summary
Update required module version
go.mod
The required version of github.com/maxmind/mmdbwriter/v2 changes to v2.0.0-20261103192512-94d3a330ab9c.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: horgh

Merge Risk: Minimal · up to 82e5c

This updates a dependency to a newer upstream commit so the untagged-dependency check passes. No behavior change or user-facing impact is expected, and it is low risk to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "STF-2368: Update mmdbwriter to the latest main commit" matches the only functional change in the changeset, which bumps github.com/maxmind/mmdbwriter/v2 in go.mod to a newer pseudo-version.…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "STF-2368: Update mmdbwriter to the latest main commit" matches the only functional change in the changeset, which bumps github.com/maxmind/mmdbwriter/v2 in go.mod to a newer pseudo-version. It names the dependency and the update. It does not explain why the update was made, but the objectives say it fixes Check Untagged Dependencies failing on a pseudo-versioned dependency. The ticket prefix is a reference, not noise that makes the title unclear.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the module line,
A newer version joins the file.
The old one hops away in time,
The new one settles for a while.
Then off the rabbit bounds with style.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3fcf7499-c6bb-4e8a-b126-b1fe5083df83
Commits

Reviewing files that changed from the base of the PR and between 311ac2a and 82e5cc2.

Files ignored due to path filters: 1

  • go.sum is excluded by !**/*.sum
Files selected for processing: 1

  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@mm-kevcenteno
mm-kevcenteno merged commit 83807e9 into main Nov 14, 2026
19 checks passed
@mm-kevcenteno
mm-kevcenteno deleted the greg/stf-2368-mmdbwriter-pseudo branch November 14, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants