Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/jsonschema model #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Features/jsonschema model #2

wants to merge 6 commits into from
+244 −11

Conversation

Floris272
Copy link
Collaborator

@Floris272 Floris272 commented Jan 7, 2025 •
edited
Loading

Added JsonSchema model

Questions:

  • I assume JsonSchemas should be able to be created within the producttype api, should the serializer and other stuff be added here or in Open Producten?
  • One issue with api either way is that the fields of JsonSchema are currently in english as this is a package. I did add NL translations but the fields themselves will be in english in the api.

@Floris272 Floris272 linked an issue Jan 7, 2025 that may be closed by this pull request
Product verbruiksobjecten maykinmedia/open-producten#5
Open
@Floris272 Floris272 force-pushed the features/jsonschema-model branch from d02b552 to a3ba79c Compare January 7, 2025 14:08
@Floris272 Floris272 force-pushed the features/jsonschema-model branch from a3ba79c to 1d65612 Compare January 7, 2025 14:11
@Floris272 Floris272 requested a review from alextreme January 8, 2025 10:30
alextreme
alextreme reviewed Jan 8, 2025
View reviewed changes
README.rst Outdated Show resolved Hide resolved
alextreme
alextreme reviewed Jan 8, 2025
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@alextreme
Copy link
Member

I assume JsonSchemas should be able to be created within the producttype api, should the serializer and other stuff be added here or in Open Producten?

I would leave this in Open Producten for now, otherwise you'll also have to depend on DRF and the rest

One issue with api either way is that the fields of JsonSchema are currently in english as this is a package. I did add NL translations but the fields themselves will be in english in the api.

This feels fine for the time being

alextreme
alextreme approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeribekker wil jij hier nog naar kijken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product verbruiksobjecten
2 participants
@Floris272 @alextreme