Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#521] OIDC through django config #532

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Dec 5, 2024

Fixes #521

@SilviaAmAm SilviaAmAm marked this pull request as draft December 5, 2024 13:26
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (135f8a3) to head (bf7120b).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #532       +/-   ##
===========================================
- Coverage   91.07%   80.16%   -10.92%     
===========================================
  Files         110      205       +95     
  Lines        3495     5585     +2090     
  Branches        0      556      +556     
===========================================
+ Hits         3183     4477     +1294     
- Misses        312     1108      +796     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the feature/521-oidc-through-django-config branch from 216ab34 to e52f431 Compare December 5, 2024 14:54
@SilviaAmAm SilviaAmAm marked this pull request as ready for review December 5, 2024 15:49
@SilviaAmAm SilviaAmAm requested a review from swrichards December 5, 2024 15:49
Copy link

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick, otherwise LGTM.

@SilviaAmAm SilviaAmAm merged commit 8f56121 into main Dec 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Admin-OIDC configuration via django-setup-configuration
3 participants