⚡ - perf: attempt to increase performance of DestructionList rela… #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 80.34% 80.79% +0.44%
==========================================
Files 204 206 +2
Lines 5596 5628 +32
Branches 560 567 +7
==========================================
+ Hits 4496 4547 +51
+ Misses 1100 1081 -19 ☔ View full report in Codecov by Sentry. |
svenvandescheur
force-pushed
the
feature/performance
branch
2 times, most recently
from
e57b627 to
1e92c7e
Compare
SilviaAmAm
reviewed
Dec 12, 2024
svenvandescheur
force-pushed
the
feature/performance
branch
2 times, most recently
from
01753ef to
58247f9
Compare
SilviaAmAm
approved these changes
Dec 16, 2024
svenvandescheur
force-pushed
the
feature/performance
branch
from
fa45414 to
9ba0080
Compare
svenvandescheur
force-pushed
the
feature/performance
branch
from
9ba0080 to
155ea28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ted API endpoints
On my machine™: from 114 queries to 18 on http://localhost:8000/api/v1/destruction-lists/
Not sure if/how this intervenes with the performance tests though...