-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve alias generator #1
Comments
the function needs to be made better or just more nouns and adjectives added to the list? |
Ideally the function is to be improved but additions to the existing lists are also welcome. |
Hi! I am new to this community. Can I work on this? |
"made better" is not much of a guideline. What's the problem/limitation that you see in it? |
Yes "made better" is misleading and confusing. I was interested in two things. One, which is easy, adding to the existing pool of nouns and adjectives. Two, which is open-ended and I haven't come up with any idea yet, is to create a new way to generate aliases which we can somehow say is a better way. Yes it's vague, but I think something might come up in discussion. |
I was working on something last night. I'll send it to you today. |
Just submitted a new change to the generator (a refactoring change). |
I did not change the generator itself, but i added some words and organized some of the entries there. |
Hey, is anyone working on this at the moment? |
Hi. I have compiled a list of 1339 adjectives that could be used as prefixes if it could be of any interest to add, if you are still working on this :) |
Hi I'm new here what exactly do you want to improve how aliases are generated or more values in the list? Can you elaborate on what needs to be done. Thanks in advance |
Could I work on this? |
If I might ask, is the gender division logic necessary? |
@Vyvy-vi You are correct. Thank you for pointing this out straight away. Although I kept this open without much scrutiny, just so people can have the experience of having a PR, it seems there are very bad examples creeping in. Honestly, I had faith people won't mess this up. I would clear up the bad clutter when I have some time. But since you are interested, I would be happy if you wanted to help with it. |
If you guy's don't mind can I aid in this venture. Sorry about the seixst
thing I didn't see it while I was working on it
…On Thu, Dec 31, 2020, 10:07 PM Vyom Jain ***@***.***> wrote:
I did a rework of the generator. Slightly improved the randomisation and
added a larger descriptor variety pool.
(Tho it's far from perfect as of now). Tried to keep gender classification
limited to the first names
I plan on setting a name_length limit, to prevent the single names from
appearing, like 'Sailor', 'Baratheon'
Here are a few samples:
[image: Screenshot 2020-12-31 at 10 33 55 PM]
<https://user-images.githubusercontent.com/62864373/103419295-7261a680-4bb8-11eb-83dd-e9bea5a48ac9.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK7LYH3GQZPTKKOBJSNHOILSXSVTTANCNFSM4D5CQAFQ>
.
|
I have opened a draft PR with the changes |
@fear-the-reaper You can make improvements once @Vyvy-vi's changes are merged. You can start now and rebase later too if needed. |
Hello @mayukh18 |
What is the status of this issue? |
To improve your alias generator, you can consider several enhancements to make it more sophisticated and versatile. Here are some ideas to take your alias generator to the next level:
Remember that the key to making your alias generator better is to provide a wide range of options and customization while keeping the user experience simple and intuitive. Tailor your improvements to the specific needs and interests of your target audience. |
Maybe improve the alias generator with something like the introduction of namefake.com api? |
alias generator is the simplest right now. Needs to be made better.
The text was updated successfully, but these errors were encountered: