Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue #1 discussed on 2 main improvements to be made:
This PR splits the lists into more DESCRIPTORS, in order to generate more customised names, moreover, this aims at cleaning up the data a bit, and create a more inclusive classifier dataset. The algorithm has been slightly customised and a new parameter has been added, to cap the max_length at random. (still under work)
Q) Would this new param change production in anything else?
Ans- No. The parameter has a default value, thus there won't be any issues.
Q) Why split descriptors into multiple parts?
Ans-
Q) Why is some of the code in this PR, not clean?
Ans- This PR is a draft PR. Once it's ready for review, the code would be cleaned up.
Q) Why is there a commit from ImgBot here?
Ans- ImgBot is an automation that runs on all of my repos.. It optimised the images in the repo... [my bad 😅 ]
Though, it didn't affect image quality or any of the code, so things should be fine 👍
Q) Why is this a draft?
Ans- There are still some improvements left to make.
This PR aims to:
Related issue:
Issue #1
Sample screenshots:
STATUS: Draft