Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "Up" and "Left" Buttons to Fixture Group Editor #1660

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

yestalgia
Copy link
Contributor

@yestalgia yestalgia commented Jan 6, 2025

Overview

This pull request enhances the Fixture Group Editor in QLC+ by adding "Up" and "Left" buttons. These buttons allow users to add fixtures to a group starting from the selected cell in the reverse directions (upwards and leftwards) of the existing "Right" and "Down" buttons.

Changes Made

Code Enhancements:

  1. Added new slots: slotUpClicked() and slotLeftClicked().
  2. Extended addFixtureHeads() to handle Qt::UpArrow and Qt::LeftArrow.

UI

  1. Added "Left" and "Up" buttons to the layout in fixturegroupeditor.ui.
  2. Configured the buttons with an appropriate tooltip and icon (:/back.png, :/up.png).
  3. Connected the buttons to slots in the constructor of FixtureGroupEditor.

Testing:

I have verified the functionality of "Up" and "Left" buttons across various scenarios, ensuring correct behaviour and bounds handling.

@yestalgia
Copy link
Contributor Author

We may need to update translations for the hover text.

@coveralls
Copy link

Coverage Status

coverage: 31.49% (-0.01%) from 31.5%
when pulling bc86fe1 on yestalgia:add/fixturegroupeditor-up-left-buttons
into 3547c9e on mcallegari:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants