Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PerformanceEventTiming members #21551

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Oct 14, 2022

Description

This PR documents the PerformanceEventTiming API members.

Motivation

openwebdocs/project#62

Additional details

I think very often it is hard to come up with good and sensible content for property pages. In fact, I think many MDN API property pages are thin. I tried to provide examples here for everything, though. I hope it doesn't look all too constructed. I think it just tells that I sometimes don't exactly know the precise use case for a property. If you have better use cases or ideas, let me know and I'm happy to make the example code better.

Related issues and pull requests

#21531 is the PR that updates the PerformanceEventTiming interface page. @wbamberg is reviewing it and it might be nice to get his review on this one as well but I won't require it :)

@Elchi3 Elchi3 requested a review from a team as a code owner October 14, 2022 12:44
@Elchi3 Elchi3 requested review from sideshowbarker and removed request for a team October 14, 2022 12:44
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 14, 2022
@Elchi3 Elchi3 force-pushed the perfeventtiming-members branch from bbeddcd to c2ca7fd Compare October 14, 2022 12:50
Copy link
Collaborator

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, with some copy-editing suggestions to consider

Co-authored-by: Michael[tm] Smith <[email protected]>
@sideshowbarker sideshowbarker merged commit 722b91e into mdn:main Oct 16, 2022
@Elchi3 Elchi3 deleted the perfeventtiming-members branch October 16, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants