Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PerformanceMark/PerformanceMeasure.detail #21823

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Oct 25, 2022

Description

This PR adds details! 🥁💤

Motivation

openwebdocs/project#62

Additional details

Spec: https://w3c.github.io/user-timing/#performancemark & https://w3c.github.io/user-timing/#performancemeasure

Related issues and pull requests

Will submit a BCD PR for the mdn_urls later.

@Elchi3 Elchi3 requested a review from a team as a code owner October 25, 2022 14:51
@Elchi3 Elchi3 requested review from jpmedley and removed request for a team October 25, 2022 14:51
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Preview URLs

Flaws (2)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PerformanceMark/detail
Title: PerformanceMark.detail
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PerformanceMark/PerformanceMark does not exist
    • /en-US/docs/Web/API/PerformanceMark/PerformanceMark does not exist

(this comment was updated 2022-10-26 16:32:54.224693)

Copy link
Collaborator

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have a few suggestions though.

files/en-us/web/api/performancemark/detail/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performancemark/detail/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performancemeasure/detail/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performancemeasure/detail/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performancemeasure/detail/index.md Outdated Show resolved Hide resolved
@jpmedley jpmedley merged commit 304ef7f into mdn:main Oct 26, 2022
@Elchi3 Elchi3 deleted the perfmark-perfmeasure-detail branch October 27, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants