Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info for buffered flag; be consistent in examples #22768

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 6, 2022

Description

This PR makes updates to the PerformanceResourceTiming and PerformanceServerTiming examples to explain why it is a good idea to use the buffered flag. It also makes the language consistent and avoids fragment sentences.

This is in response to feedback from previous PRs. Thank you, Joe and Will.

Motivation

openwebdocs/project#62

Additional details

The PerformanceServerTiming examples are interesting as they want multiple types and buffered. I wrapped the observe call in a forEach.

Related issues and pull requests

Previous PRs where this came up, e.g. #22683 (comment).

@Elchi3 Elchi3 requested a review from a team as a code owner December 6, 2022 12:15
@Elchi3 Elchi3 requested review from wbamberg and removed request for a team December 6, 2022 12:16
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Preview URLs (27 pages)
Flaws (1)

Note! 26 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Title: PerformanceResourceTiming.responseStatus
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.PerformanceResourceTiming.responseStatus

(comment last updated: 2022-12-06 12:36:54)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you Florian!

@wbamberg wbamberg merged commit b3477f9 into mdn:main Dec 9, 2022
@Elchi3 Elchi3 deleted the conistency-buffered branch December 9, 2022 12:40
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request Dec 12, 2022
* Add info for buffered flag; be consistent in examples

* More tweaks for server timing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants