Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pages: missing checkvalidity() and reportvalidity() API method pages #35546

Merged
merged 19 commits into from
Aug 30, 2024
Merged

New pages: missing checkvalidity() and reportvalidity() API method pages #35546

merged 19 commits into from
Aug 30, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Aug 22, 2024 •
edited
Loading

These are not important pages, but they fix broken links.

part of #35544

@estelle estelle requested a review from a team as a code owner August 22, 2024 03:45
@estelle estelle requested review from sideshowbarker and removed request for a team August 22, 2024 03:45
@github-actions github-actions bot added Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed labels Aug 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

Preview URLs (16 pages)
Flaws (24)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLFormElement/checkValidity
Title: HTMLFormElement: checkValidity() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event

URL: /en-US/docs/Web/API/HTMLFormElement/reportValidity
Title: HTMLFormElement: reportValidity() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event

URL: /en-US/docs/Web/API/HTMLSelectElement/checkValidity
Title: HTMLSelectElement: checkValidity() method
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event
    • /en-US/docs/Web/API/HTMLSelectElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLSelectElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLSelectElement/validity does not exist

URL: /en-US/docs/Web/API/HTMLSelectElement/reportValidity
Title: HTMLSelectElement: reportValidity() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event

URL: /en-US/docs/Web/API/HTMLInputElement/checkValidity
Title: HTMLInputElement: checkValidity() method
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event
    • /en-US/docs/Web/API/HTMLInputElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLInputElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLInputElement/validity does not exist

URL: /en-US/docs/Web/API/HTMLInputElement/reportValidity
Title: HTMLInputElement: reportValidity() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event

URL: /en-US/docs/Web/API/HTMLButtonElement/checkValidity
Title: HTMLButtonElement: checkValidity() method
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event
    • /en-US/docs/Web/API/HTMLButtonElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/setCustomValidity does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/validity does not exist

URL: /en-US/docs/Web/API/HTMLButtonElement/reportValidity
Title: HTMLButtonElement: reportValidity() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event

URL: /en-US/docs/Web/API/HTMLTextAreaElement/checkValidity
Title: HTMLTextAreaElement: checkValidity() method
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event
    • /en-US/docs/Web/API/HTMLTextAreaElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLTextAreaElement/setCustomValidity does not exist
    • /en-US/docs/Web/API/HTMLTextAreaElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLTextAreaElement/validity does not exist

URL: /en-US/docs/Web/API/HTMLTextAreaElement/reportValidity
Title: HTMLTextAreaElement: reportValidity() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event

(comment last updated: 2024-08-30 16:37:39)

@estelle estelle mentioned this pull request Aug 22, 2024
Closed
@sideshowbarker sideshowbarker removed their request for review August 22, 2024 17:15
@estelle estelle requested a review from Josh-Cena August 22, 2024 19:14
Josh-Cena
Josh-Cena reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should give an "invalid" live example for each reportValidity page, to show readers what the default reporting UI looks like. What do you think?

files/en-us/web/api/htmlformelement/checkvalidity/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlformelement/checkvalidity/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltextareaelement/checkvalidity/index.md Outdated Show resolved Hide resolved
@estelle estelle requested a review from Josh-Cena August 27, 2024 22:50
@Josh-Cena
Copy link
Member

Instead of me making a bunch of comments, can I just commit to this branch?

@estelle
Copy link
Member Author

estelle commented Aug 29, 2024

Instead of me making a bunch of comments, can I just commit to this branch?

Yup. Definitely. If you want to submit a PR to my branch, that works too.

Josh-Cena
Josh-Cena approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not make any significant content changes, only consistency refactors, so merging. This looks good :)

@Josh-Cena Josh-Cena merged commit 89d17a6 into main Aug 30, 2024
9 checks passed
@Josh-Cena Josh-Cena deleted the reportvalidity branch August 30, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @Josh-Cena