Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pages: HTML<formelements>Element.value properties #35641

Merged
merged 4 commits into from
Aug 30, 2024
Merged

New pages: HTML<formelements>Element.value properties #35641

merged 4 commits into from
Aug 30, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Aug 29, 2024

part of #35544

@estelle estelle requested a review from a team as a code owner August 29, 2024 20:37
@estelle estelle requested review from wbamberg and removed request for a team August 29, 2024 20:37
@github-actions github-actions bot added the Content:WebAPI Web API docs label Aug 29, 2024
@estelle estelle changed the title New pages: HTML<x>Element.value properties New pages: HTML<formelements>Element.value properties Aug 29, 2024
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Preview URLs

Flaws (9)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLOutputElement/value
Title: HTMLOutputElement: value property
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/HTMLOutputElement/defaultValue does not exist
    • /en-US/docs/Web/API/HTMLOutputElement/defaultValue does not exist
    • /en-US/docs/Web/API/HTMLOutputElement/htmlFor does not exist

URL: /en-US/docs/Web/API/HTMLTextAreaElement/value
Title: HTMLTextAreaElement: value property
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/HTMLTextAreaElement/textLength does not exist
    • /en-US/docs/Web/API/HTMLTextAreaElement/selectionStart does not exist
    • /en-US/docs/Web/API/HTMLTextAreaElement/selectionEnd does not exist

URL: /en-US/docs/Web/API/HTMLOptionElement/value
Title: HTMLOptionElement: value property
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/HTMLOptionElement/selected does not exist
    • /en-US/docs/Web/API/HTMLOptionElement/defaultSelected does not exist
    • /en-US/docs/Web/API/HTMLOptionElement/label does not exist

(comment last updated: 2024-08-30 18:39:43)

Josh-Cena
Josh-Cena reviewed Aug 29, 2024
View reviewed changes
files/en-us/web/api/htmltextareaelement/value/index.md Outdated

{{ APIRef("HTML DOM") }}

The **`value`** property of the {{DOMxRef("HTMLTextAreaElement")}} interface represents the value of the {{htmlelement("textarea")}} element as a string, which is an empty string if the widget contains no content. It reflects the raw value contained in the control.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Reflect attribute x" is a proper term in HTML, which means it acts as a proxy for getting/setting the attribute value. Therefore you don't use "reflect" for anything other than attributes. (You can know whether a property reflects an attribute by checking the spec.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to "returns or sets"

files/en-us/web/api/htmltextareaelement/value/index.md Outdated Show resolved Hide resolved
@estelle estelle requested a review from Josh-Cena August 30, 2024 16:49
Josh-Cena
Josh-Cena approved these changes Aug 30, 2024
View reviewed changes
files/en-us/web/api/htmlbuttonelement/value/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlbuttonelement/value/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmloutputelement/value/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmloutputelement/value/index.md Outdated Show resolved Hide resolved
Josh-Cena
Josh-Cena approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed a few typos. This looks great!

@Josh-Cena Josh-Cena merged commit 45eeb37 into main Aug 30, 2024
9 checks passed
@Josh-Cena Josh-Cena deleted the values branch August 30, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @Josh-Cena