Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pages for HTML*Element.validity #35660

Merged
merged 4 commits into from
Sep 10, 2024
Merged

New pages for HTML*Element.validity #35660

merged 4 commits into from
Sep 10, 2024

Conversation

Josh-Cena
Copy link
Member

Part of #35544

@Josh-Cena Josh-Cena requested a review from a team as a code owner August 31, 2024 18:37
@Josh-Cena Josh-Cena requested review from wbamberg and removed request for a team August 31, 2024 18:37
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Aug 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 31, 2024 •
edited
Loading

Preview URLs (10 pages)
Flaws (5)

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLButtonElement/checkValidity
Title: HTMLButtonElement: checkValidity() method
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event
    • /en-US/docs/Web/API/HTMLButtonElement/validationMessage does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/setCustomValidity does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/validationMessage does not exist

URL: /en-US/docs/Web/API/HTMLFormElement/checkValidity
Title: HTMLFormElement: checkValidity() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/invalid_event redirects to /en-US/docs/Web/API/HTMLInputElement/invalid_event

(comment last updated: 2024-09-10 17:34:24)

@Josh-Cena Josh-Cena requested review from estelle and removed request for wbamberg August 31, 2024 18:41
estelle
estelle reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two edits that need to be made.

Otherwise, I gave feedback for the first three pages. This feedback is the same for all pages. Please take a look and see if you agree (and update all), or disagree and updated none.

files/en-us/web/api/htmlbuttonelement/validity/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlbuttonelement/validity/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlfieldsetelement/validity/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlfieldsetelement/validity/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlfieldsetelement/validity/index.md Show resolved Hide resolved
files/en-us/web/api/htmlformelement/checkvalidity/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlfieldsetelement/checkvalidity/index.md Show resolved Hide resolved
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Sep 10, 2024
@Josh-Cena Josh-Cena requested a review from estelle September 10, 2024 17:29
estelle
estelle approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 2b29051 into mdn:main Sep 10, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the validity branch September 10, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @estelle