Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page for reflection properties of HTMLTextAreaElement #35664

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

Josh-Cena
Copy link
Member

Part of #35544

@Josh-Cena Josh-Cena requested a review from a team as a code owner August 31, 2024 20:05
@Josh-Cena Josh-Cena requested review from wbamberg and removed request for a team August 31, 2024 20:05
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Aug 31, 2024
@Josh-Cena Josh-Cena requested review from estelle and removed request for wbamberg August 31, 2024 20:06
Copy link
Contributor

github-actions bot commented Aug 31, 2024

Preview URLs (10 pages)
Flaws (2)

Note! 9 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLTextAreaElement/textLength
Title: HTMLTextAreaElement: textLength property
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLTextAreaElement/minLength does not exist
    • /en-US/docs/Web/API/HTMLTextAreaElement/maxLength does not exist

(comment last updated: 2024-09-11 01:11:32)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only partially reviewed. Will continue in a few hours.


## Value

See [`wrap`](/en-US/docs/Web/HTML/Element/textarea#wrap) for the possible values. Defaults to `"soft"`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [`wrap`](/en-US/docs/Web/HTML/Element/textarea#wrap) for the possible values. Defaults to `"soft"`.
The value of the `wrap` property, if set. Otherwise, the empty string.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The wrap property has the value of the wrap property" is a tautology. I assume you mean "it reflects the value of the wrap attribute" but that's already mentioned above.


{{ APIRef("HTML DOM") }}

The **`wrap`** property of the {{DOMxRef("HTMLTextAreaElement")}} interface indicates how the control should wrap the value for form submission. It reflects the `<textarea>` element's [`wrap`](/en-US/docs/Web/HTML/Element/textarea#wrap) attribute. Note that the `"hard"` value only has an effect when the {{domxref("HTMLTextAreaElement.cols", "cols")}} attribute is also set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The **`wrap`** property of the {{DOMxRef("HTMLTextAreaElement")}} interface indicates how the control should wrap the value for form submission. It reflects the `<textarea>` element's [`wrap`](/en-US/docs/Web/HTML/Element/textarea#wrap) attribute. Note that the `"hard"` value only has an effect when the {{domxref("HTMLTextAreaElement.cols", "cols")}} attribute is also set.
The **`wrap`** property of the {{DOMxRef("HTMLTextAreaElement")}} interface indicates how a multi-line value of the form control should wrap for form submission. It reflects the `<textarea>` element's [`wrap`](/en-US/docs/Web/HTML/Element/textarea#wrap) attribute.
See [`wrap`](/en-US/docs/Web/HTML/Element/textarea#wrap) for the possible values. Defaults to `"soft"`. Note that the `"hard"` value only has an effect when the {{domxref("HTMLTextAreaElement.cols", "cols")}} attribute is also set.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mention the "values" below in its own section.

files/en-us/web/api/htmltextareaelement/wrap/index.md Outdated Show resolved Hide resolved
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really minor suggestions

files/en-us/web/api/htmltextareaelement/cols/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltextareaelement/cols/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltextareaelement/required/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmltextareaelement/rows/index.md Outdated Show resolved Hide resolved
@Josh-Cena Josh-Cena requested a review from estelle September 11, 2024 05:01
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 30d0a92 into mdn:main Sep 11, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the textarea-props branch September 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants