Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pages for HTMLOutputElement.{defaultValue,htmlFor} #36017

Merged
merged 2 commits into from
Oct 4, 2024
Merged

New pages for HTMLOutputElement.{defaultValue,htmlFor} #36017

merged 2 commits into from
Oct 4, 2024

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena requested a review from a team as a code owner September 23, 2024 15:57
@Josh-Cena Josh-Cena requested review from sideshowbarker and removed request for a team September 23, 2024 15:57
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-10-02 23:54:21)

@Josh-Cena Josh-Cena requested review from estelle and removed request for sideshowbarker September 23, 2024 15:59
estelle
estelle reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest making the example's HTML more accessible

files/en-us/web/api/htmloutputelement/defaultvalue/index.md Outdated Show resolved Hide resolved
@Josh-Cena Josh-Cena requested a review from estelle October 2, 2024 23:53
estelle
estelle approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 4c8b753 into mdn:main Oct 4, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the output-props branch October 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @estelle