Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pages: HTMLMediaElement API (played and seeking) #37006

Merged
merged 10 commits into from
Jan 7, 2025
Merged

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 27, 2024

part of Missing baseline pages project

@estelle estelle requested a review from a team as a code owner November 27, 2024 19:52
@estelle estelle requested review from wbamberg and removed request for a team November 27, 2024 19:52
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Nov 27, 2024
@estelle estelle changed the title New pages: htmlmediaelement API New pages: HTMLMediaElement API (played and seeking) Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

Preview URLs

(comment last updated: 2025-01-06 21:51:00)

@arinthros
Copy link

Thank you @estelle! I was looking to add played because I needed it this week and discovered it was missing, and here is an MR already opened for it.

@arinthros
Copy link

Should these also be added as entries into the main HTMLMediaElement page?

- {{domxref("HTMLMediaElement.buffered")}} {{ReadOnlyInline}}

I'm new to this repo, so maybe they're scooped up in a build job, but it looks like the properties are also enumerated in the parent element page by hand.

@estelle
Copy link
Member Author

estelle commented Dec 5, 2024

Should these also be added as entries into the main HTMLMediaElement page?

- {{domxref("HTMLMediaElement.buffered")}} {{ReadOnlyInline}}

I'm new to this repo, so maybe they're scooped up in a build job, but it looks like the properties are also enumerated in the parent element page by hand.

I am not sure if this was your question, but the two properties are already on the landing page. See https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement#htmlmediaelement.played.

files/en-us/web/api/htmlmediaelement/played/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmediaelement/played/index.md Outdated Show resolved Hide resolved
timePlayed += playedTimeRanges.end(i) - playedTimeRanges.start(i);
}
console.log(`The media played for a total of ${timePlayed} seconds.`);
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to see this as a live sample.

- {{domxref("HTMLMediaElement.progress_event", "progress")}} event
- {{domxref("HTMLMediaElement.seekable")}}
- {{domxref("HTMLMediaElement.buffered")}}
- {{domxref("HTMLMediaElement")}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should link to the parent here.


{{APIRef("HTML DOM")}}

The readonly **`seeking`** property of the {{domxref("HTMLMediaElement")}} interface is a boolean indicating whether the media, the {{htmlelement("audio")}} or {{htmlelement("audio")}}, is in the process of seeking to a new position.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly the same comments for this paragraph.


- {{domxref("HTMLMediaElement.seeking_event", "seeking")}} event
- {{domxref("HTMLMediaElement.seeked_event", "seeked")}} event
- {{domxref("HTMLMediaElement")}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment.

@estelle estelle requested a review from wbamberg January 6, 2025 18:55
@wbamberg
Copy link
Collaborator

wbamberg commented Jan 6, 2025

It still says <audio> or <audio>.

@estelle
Copy link
Member Author

estelle commented Jan 6, 2025

It still says <audio> or <audio>.

fixed. I was going to ask "How did I not see that?" but I know exactly why ...

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you Estelle!

@wbamberg wbamberg merged commit 2e84c22 into main Jan 7, 2025
9 checks passed
@wbamberg wbamberg deleted the htmlmediaelement2 branch January 7, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants