Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify about poetry #239

Closed
wants to merge 4 commits into from
Closed

Clarify about poetry #239

wants to merge 4 commits into from

Conversation

robkam
Copy link
Member

@robkam robkam commented May 20, 2024

No description provided.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't currently review documentation changes - Let us know if you'd like us to change this.

@robkam robkam enabled auto-merge (squash) May 20, 2024 10:58
@elsiehupp
Copy link
Member

I vaguely remembered the Poetry installation being somewhat weird, so I checked the documentation, and it says to use pipx instead of pip:

pipx install poetry

pipx appears to have its own setup process (with different instructions depending platform). (That is, pipx is apparently not installed by default with Python.)

I think what I was remembering was that previously Poetry used curl for installation, but pipx appears to abstract away some of the complexity.

@robkam
Copy link
Member Author

robkam commented Jun 5, 2024

pipx installs and runs Python applications in isolated environments. As yet we've not yet done anything like that with MediaWiki Dump Generator.

@robkam
Copy link
Member Author

robkam commented Jun 5, 2024

Perhaps including instructions for installing poetry is getting out of scope?

@robkam
Copy link
Member Author

robkam commented Jun 6, 2024

Instructions for installing poetry is out of scope.

@robkam robkam closed this Jun 6, 2024
auto-merge was automatically disabled June 6, 2024 15:44

Pull request was closed

@randomnetcat randomnetcat deleted the robkam-poetry branch September 24, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants