Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Chore: fix linting issues" & fix linting #405

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Revert "Chore: fix linting issues" & fix linting #405

merged 3 commits into from
Jan 10, 2025

Conversation

curquiza
Copy link
Member

Reverts #403

@ahmednfwela
Copy link
Collaborator

i will fix the lints in this PR

@curquiza
Copy link
Member Author

Thank you Ahmed

@ahmednfwela ahmednfwela self-requested a review January 10, 2025 11:41
ahmednfwela
ahmednfwela approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ahmednfwela ahmednfwela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 10, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 58fc5a9 into main Jan 10, 2025
6 checks passed
@meili-bors meili-bors bot deleted the revert-403-chore/fix-linting-issues branch January 10, 2025 11:46
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jan 10, 2025
@curquiza curquiza changed the title Revert "Chore: fix linting issues" Revert "Chore: fix linting issues" & fix linting Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmednfwela ahmednfwela ahmednfwela approved these changes

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @ahmednfwela