-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Meshery Adapter for Kuma to Go version to 1.23 #443
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
Workflow run approved. Build checks in progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to upgrade to the v5 version of the go action.
So many uses of that go action seems redundant and like unnecessary overhead and an opportunity for consolidation.
Regarding line 18 of .github/workflows/build-and-release.yml any other occurrences: |
@leecalcote fixed some golangci-lint suggestions and updated the go action version. waiting for you opinion! |
Running build workflows.... |
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
updated: dominikh/staticcheck-action@v1 due to deprecated feature (source) |
Signed-off-by: devhindo <[email protected]>
please rerun @leecalcote |
Re-running |
Regarding this failure, I wonder if this action, https://github.com/dominikh/staticcheck-action, can be replaced by another action, like golanglint-ci |
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
we were just using a deprecated version. please rerun @leecalcote |
Let's push forth with a merge here and see where we stand afterwards.... |
Just updated Dockerfile and Workflows to go v23 and everything seems to work fine
fixes #441