Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Meshery Adapter for Kuma to Go version to 1.23 #443

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

devhindo
Copy link
Member

@devhindo devhindo commented Dec 12, 2024

Just updated Dockerfile and Workflows to go v23 and everything seems to work fine

fixes #441

Copy link

welcome bot commented Dec 12, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@leecalcote
Copy link
Member

Workflow run approved. Build checks in progress.

@leecalcote leecalcote added kind/chore Necessary task language/go Issues or pull requests that use Golang labels Dec 12, 2024
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to upgrade to the v5 version of the go action.

So many uses of that go action seems redundant and like unnecessary overhead and an opportunity for consolidation.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/error-ref-publisher.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/update-oam-defs.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-release.yml Outdated Show resolved Hide resolved
@devhindo
Copy link
Member Author

devhindo commented Dec 12, 2024

Regarding line 18 of .github/workflows/build-and-release.yml any other occurrences:
should we also update actions/checkout@v4 ?

@devhindo
Copy link
Member Author

@leecalcote fixed some golangci-lint suggestions and updated the go action version. waiting for you opinion!

@leecalcote
Copy link
Member

Running build workflows....

@devhindo
Copy link
Member Author

updated: dominikh/staticcheck-action@v1 due to deprecated feature (source)

@devhindo
Copy link
Member Author

please rerun @leecalcote

@leecalcote
Copy link
Member

Re-running

@leecalcote
Copy link
Member

leecalcote commented Dec 12, 2024

Regarding this failure, I wonder if this action, https://github.com/dominikh/staticcheck-action, can be replaced by another action, like golanglint-ci

@devhindo
Copy link
Member Author

we were just using a deprecated version. please rerun @leecalcote
I'm also wondering what's the issue with this action as the logs doesn't show anything userful.

@devhindo devhindo changed the title Update Go version to 1.23 Updating Meshery Adapter for Kuma to Go version to 1.23 Dec 13, 2024
@leecalcote
Copy link
Member

Let's push forth with a merge here and see where we stand afterwards....

@leecalcote leecalcote merged commit 097bdff into meshery:master Dec 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Necessary task language/go Issues or pull requests that use Golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] Upgrade to Golang 1.23.4
2 participants