Handle millis() overflow

Avoid getting stuck in a while loop
meshtastic · Mar 28, 2024 · f5fdbe0 · f5fdbe0
1 parent ffc1658
commit f5fdbe0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/graphics/Screen.cpp b/src/graphics/Screen.cpp
@@ -1364,8 +1364,10 @@ void Screen::setScreensaverFrames(FrameCallback einkScreensaver)
     // Request new frame, ASAP
     setFastFramerate();
     uint64_t now = millis();
-    while (ui->getUiState()->lastUpdate < now)
+    while (ui->getUiState()->lastUpdate < now) {
         ui->update();
+        now = millis(); // Handle millis() overflow
+    }
 
 #ifndef USE_EINK_DYNAMICDISPLAY
     // Retrofit to EInkDisplay class
@@ -1960,4 +1962,4 @@ int Screen::handleInputEvent(const InputEvent *event)
 } // namespace graphics
 #else
 graphics::Screen::Screen(ScanI2C::DeviceAddress, meshtastic_Config_DisplayConfig_OledType, OLEDDISPLAY_GEOMETRY) {}
-#endif // HAS_SCREEN
+#endif // HAS_SCREEN