Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new NRF52 board, MeshLink #5736
base: master
Are you sure you want to change the base?
Add support for new NRF52 board, MeshLink #5736
Changes from 4 commits
8f48fd4
b7329c4
8f584bb
e4e1cda
62a0988
f08bd94
8ed7ae7
1c05c0b
f434525
022702f
c82f23e
ff92b86
535b89d
4442a9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason behind this? i am asking because maybe we already have a way to accomodate this without the macro guards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the PIN_3V3_EN definition for the watchdog enable pin, because i needed a pin that would have been turned off automatically by the firmware when we put the cpu to sleep with button longpress. Otherwise, the watchdog would remain enabled without being reset by the status led blink (because the cpu is sleeping). I could rename it to WD_EN and add a specific digitalwrite for my board in main-nrf52.cpp and src/sleep.cpp. I just noticed that there could also be an edge case scenario problem when using repeater role as 3v3_en pin would be disabled on startup
https://github.com/ponzano/MeshLink/blob/c82f23ed2aa81cb09ba4e57e281347da74e02cb0/src/main.cpp#L649C5-L649C121