Corrected String lengths for SSID and NTP server name #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobi-sys is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
relates to the pull request meshtastic/protobufs#402 |
caveman99
approved these changes
Nov 15, 2023
According to the source in in /firmware/src/mesh/generated/meshtastic/config.pb.h the declarations are char wifi_ssid[33]; char ntp_server[33]; so these variables can hold 32 characters and the terminator \0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the source in in /firmware/src/mesh/generated/meshtastic/config.pb.h the declarations are
char wifi_ssid[33];
char ntp_server[33];
so these variables can hold 32 characters and the terminator \0