Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate GPS attempt time #419

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Deprecate GPS attempt time #419

merged 1 commit into from
Jan 6, 2024

Conversation

thebentern
Copy link
Contributor

Closes #407

@thebentern thebentern changed the title Deprecate attempt time Deprecate GPS attempt time Jan 6, 2024
code8buster
code8buster approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@code8buster code8buster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only places in firmware this is used is in GPS::getWakeTime and during the NodeDB::initconfigintervals. The latter could simply be removed, and the former replaced by the update interval.

@thebentern thebentern merged commit 2ccf734 into master Jan 6, 2024
1 check passed
@thebentern thebentern deleted the deprecate-attempt-time branch January 6, 2024 20:33
@jp-bennett
Copy link
Contributor

Only places in firmware this is used is in GPS::getWakeTime and during the NodeDB::initconfigintervals. The latter could simply be removed, and the former replaced by the update interval.

What would this do for initial GPS fix? If someone sets a really quick GPS update interval, would it prevent ever getting an initial fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code8buster code8buster code8buster approved these changes

@caveman99 caveman99 Awaiting requested review from caveman99

@garthvh garthvh Awaiting requested review from garthvh

@jp-bennett jp-bennett Awaiting requested review from jp-bennett

@sachaw sachaw Awaiting requested review from sachaw

@ajmcquilkin ajmcquilkin Awaiting requested review from ajmcquilkin

@andrekir andrekir Awaiting requested review from andrekir

@GUVWAF GUVWAF Awaiting requested review from GUVWAF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Position.GPS_Attempt_Time and use the broadcast interval.
3 participants
@thebentern @jp-bennett @code8buster