Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ModuleSettings and position_precision to ChannelSettings #448

Merged
merged 4 commits into from
Feb 22, 2024
Merged

adds ModuleSettings and position_precision to ChannelSettings #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66e138c
adds ModuleSettings and position_precision to ChannelSettings
jp-bennett Feb 21, 2024
93c1b33
revert channel_precision
jp-bennett Feb 22, 2024
083d9e7
Properly put module_settings inside the Channelsettings message
jp-bennett Feb 22, 2024
df08595
Add precision_bits to location messages
jp-bennett Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion meshtastic/channel.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,21 @@ message ChannelSettings {
* If true, messages seen on the internet will be forwarded to the local mesh.
*/
bool downlink_enabled = 6;

/*
* Per-channel module settings.
*/
ModuleSettings module_settings = 7;
}

/*
* This message is specifically for modules to store per-channel configuration data.
*/
message ModuleSettings {
/*
* Bits of precision for the location sent in position packets.
*/
uint32 position_precision = 1;
}

/*
Expand Down Expand Up @@ -132,4 +147,4 @@ message Channel {
* TODO: REPLACE
*/
Role role = 3;
}
}
2 changes: 0 additions & 2 deletions meshtastic/config.options
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,3 @@
*LoRaConfig.channel_num int_size:16

*PowerConfig.device_battery_ina_address int_size:8

*PositionConfig.channel_precision max_count:8
5 changes: 0 additions & 5 deletions meshtastic/config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,6 @@ message Config {
* Set where GPS is enabled, disabled, or not present
*/
GpsMode gps_mode = 13;

/*
* Set GPS precision in bits per channel, or 0 for disabled
*/
repeated uint32 channel_precision = 14;
}

/*
Expand Down
5 changes: 5 additions & 0 deletions meshtastic/mesh.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,11 @@ message Position {
* detect lost updates if needed
*/
uint32 seq_number = 22;

/*
* Indicates the bits of precision set by the sending node
*/
uint32 precision_bits = 23;
}

/*
Expand Down
Loading