Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash the scheduler if the scheduler driver receives an error #429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,8 @@ public void executorLost(SchedulerDriver driver,
@Override
public void error(SchedulerDriver driver, String message) {
LOGGER.error("Scheduler driver error: {}", message);
// At this point the scheduler driver is already aborted, so there is no point staying alive.
throw new RuntimeException("Scheduler driver has been aborted because of error: " + message);
}

private List<Protos.Offer> filterAcceptedOffers(List<Protos.Offer> offers,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,13 @@ public void testMultipleRegister() throws Exception {
update();
}

@Test(expected = RuntimeException.class)
// Test that the scheduler throws a RuntimeException if the scheduler driver sends an error.
public void testSchedulerDriverError() throws Exception {
install();
scheduler.error(driver, "scheduler driver error");
}

private void update() {
scheduler.registered(driver, frameworkId, Protos.MasterInfo.getDefaultInstance());
runReconcile(driver);
Expand Down