Conversation
meta-codesync
Bot
force-pushed
the
export-D121529288
branch
from
September 24, 2026 14:40
569412a to
11d876b
Compare
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@yfeldblum has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121529288. |
yfeldblum
changed the title
meta-codesync
Bot
changed the title
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
Summary: Replaces `__builtin_clz`/`__builtin_clzl`/`__builtin_clzll` and `__builtin_ctz`/`__builtin_ctzl`/`__builtin_ctzll` with `std::countl_zero`/`std::countr_zero` in the `ClzImpl`/`CtzImpl` template specializations in `clz_impl.cpp` and `ctz_impl.cpp`, keeping the existing casts to the unsigned counterpart of each signed specialization. Differential Revision: D121529288
meta-codesync
Bot
force-pushed
the
export-D121529288
branch
from
September 25, 2026 13:19
11d876b to
248da25
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
Summary: Pull Request resolved: #4787 Replaces `__builtin_clz`/`__builtin_clzl`/`__builtin_clzll` and `__builtin_ctz`/`__builtin_ctzl`/`__builtin_ctzll` with `std::countl_zero`/`std::countr_zero` in the `ClzImpl`/`CtzImpl` template specializations in `clz_impl.cpp` and `ctz_impl.cpp`, keeping the existing casts to the unsigned counterpart of each signed specialization. Differential Revision: D121529288
meta-codesync
Bot
force-pushed
the
export-D121529288
branch
from
September 25, 2026 13:23
248da25 to
c2ede73
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
Summary: Replaces `__builtin_clz`/`__builtin_clzl`/`__builtin_clzll` and `__builtin_ctz`/`__builtin_ctzl`/`__builtin_ctzll` with `std::countl_zero`/`std::countr_zero` in the `ClzImpl`/`CtzImpl` template specializations in `clz_impl.cpp` and `ctz_impl.cpp`, keeping the existing casts to the unsigned counterpart of each signed specialization. Differential Revision: D121529288
meta-codesync
Bot
force-pushed
the
export-D121529288
branch
from
September 29, 2026 06:06
c2ede73 to
319f229
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
Summary: Pull Request resolved: #4787 Replaces `__builtin_clz`/`__builtin_clzl`/`__builtin_clzll` and `__builtin_ctz`/`__builtin_ctzl`/`__builtin_ctzll` with `std::countl_zero`/`std::countr_zero` in the `ClzImpl`/`CtzImpl` template specializations in `clz_impl.cpp` and `ctz_impl.cpp`, keeping the existing casts to the unsigned counterpart of each signed specialization. Differential Revision: D121529288
meta-codesync
Bot
force-pushed
the
export-D121529288
branch
from
September 29, 2026 06:09
319f229 to
e073ad6
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
Summary: Replaces `__builtin_clz`/`__builtin_clzl`/`__builtin_clzll` and `__builtin_ctz`/`__builtin_ctzl`/`__builtin_ctzll` with `std::countl_zero`/`std::countr_zero` in the `ClzImpl`/`CtzImpl` template specializations in `clz_impl.cpp` and `ctz_impl.cpp`, keeping the existing casts to the unsigned counterpart of each signed specialization. Differential Revision: D121529288
meta-codesync
Bot
force-pushed
the
export-D121529288
branch
from
October 1, 2026 14:12
e073ad6 to
6c2bafb
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
Summary: Pull Request resolved: #4787 Replaces `__builtin_clz`/`__builtin_clzl`/`__builtin_clzll` and `__builtin_ctz`/`__builtin_ctzl`/`__builtin_ctzll` with `std::countl_zero`/`std::countr_zero` in the `ClzImpl`/`CtzImpl` template specializations in `clz_impl.cpp` and `ctz_impl.cpp`, keeping the existing casts to the unsigned counterpart of each signed specialization. Differential Revision: D121529288
meta-codesync
Bot
force-pushed
the
export-D121529288
branch
from
October 1, 2026 14:15
6c2bafb to
99e35b7
Compare
Summary: Migrates the TorchRec dynamic-embedding bit operations to the C++20 `<bit>` APIs. - Replaces `__builtin_clz`, `__builtin_clzl`, and `__builtin_clzll`, along with the fallback `get_bit` loop and `ClzImpl` specializations, with one `Clz<T>` implementation that calls `std::countl_zero`. - Replaces `__builtin_ctz`, `__builtin_ctzl`, and `__builtin_ctzll`, along with the fallback loop and `CtzImpl` specializations, with one `Ctz<T>` implementation that calls `std::countr_zero`. - Both implementations preserve the existing signed-to-unsigned behavior by converting through `std::make_unsigned_t<T>` before counting. Differential Revision: D121529288
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
export-D121529288
branch
from
October 4, 2026 14:24
99e35b7 to
bba7dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates the TorchRec dynamic-embedding bit operations to the C++20
<bit>APIs.__builtin_clz,__builtin_clzl, and__builtin_clzll, along with the fallbackget_bitloop andClzImplspecializations, with oneClz<T>implementation that callsstd::countl_zero.__builtin_ctz,__builtin_ctzl, and__builtin_ctzll, along with the fallback loop andCtzImplspecializations, with oneCtz<T>implementation that callsstd::countr_zero.std::make_unsigned_t<T>before counting.Differential Revision: D121529288