Skip to content

Commit

Permalink
delete reconciled conditions from status KV
Browse files Browse the repository at this point in the history
  • Loading branch information
DoctorVin committed Dec 9, 2024
1 parent 0e32e22 commit fae8d6e
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions internal/orchestrator/updates.go
Original file line number Diff line number Diff line change
Expand Up @@ -608,15 +608,13 @@ func (o *Orchestrator) reconcileStatusKVEntries(ctx context.Context) {
// arguably dependencies are in a weird state, maybe return?
continue
}
// if we're here there has been a terminal error trying to reconcile this
// status value. Get rid of it now.
if err = status.DeleteCondition(evt.Kind, o.facility, evt.ConditionID.String()); err != nil {
le.WithError(err).Warn("deleting condition on reconciliation")
continue
}
}

le.Info("condition reconciled")
// don't need this anymore, get rid of it
if err := status.DeleteCondition(evt.Kind, o.facility, evt.ConditionID.String()); err != nil {
le.WithError(err).Warn("deleting condition on reconciliation")
}

if err := o.notifier.Send(evt); err != nil {
le.WithError(err).Warn("reconciler event notification")
Expand Down

0 comments on commit fae8d6e

Please sign in to comment.