-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump czmq/libzmq, statically link against them #51
base: master
Are you sure you want to change the base?
Conversation
Statically link against libzmq, czmq and libsodium, to avoid issues with dynamic linking of libzmq (see e.g. methodmissing#43). Whilst on it (mainly because the existing versions of czmq/libzmq were being a PITA to get to link statically properly), also bump the versions of libzmq and czmq. With czmq now being at API v3, also adjust the extension to be compatible with it. It still uses a fair number of deprecated APIs, but it absolutely works with API v3. Fixes methodmissing#43 Fixes methodmissing#45 (hopefully) Fixes methodmissing#47
I'm a bit puzzled as to why TestZmqBeacon#test_announce_lookup fails on Travis; I can't reproduce that locally at all - for me it just works, and provides the expected address, etc. |
I should've probably read the error message on Travis properly - it simply can't find a broadcast interface. |
Nice work :-) reviewing shortly |
Tried to repo locally, but having some build issues on OS X:
What's your local environment atm.? Also regarding Travis, looks like it references this Issue travis-ci/travis-ci#2966 which was reported by zyre which also depends on czmq. I'm OK with relaxing the test case and releasing the v3 API with a sustainable async workaround. Thoughts? |
On 26/10/2015 00:31, Lourens Naudé wrote:
||
However, with this bit of groundwork done, it should be a lot easier to |
Interesting. I just ran 'rake compile test' on my OS X (Yosemite) and it compiled just fine, and passed all the tests. Any ideas? |
Likely El Capitan specific. Will investigate further. On Monday, 26 October 2015, Alex Hornung [email protected] wrote:
|
any news on what might be the issue you are seeing? |
@paddor The main thing I'm interested in is actually to be able to statically link with just about all of the individual libraries (i.e. libzmq, czmq and libsodium). |
@brianmario Okay, never mind. :-) |
Statically link against libzmq, czmq and libsodium, to avoid issues with
dynamic linking of libzmq (see e.g. #43).
Whilst on it (mainly because the existing versions of czmq/libzmq were
being a PITA to get to link statically properly), also bump the versions
of libzmq and czmq.
With czmq now being at API v3, also adjust the extension to be
compatible with it. It still uses a fair number of deprecated APIs, but
it absolutely works with API v3.
Fixes #43
Fixes #45 (hopefully)
Fixes #47