Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if units are equivalent #57

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Check if units are equivalent #57

merged 2 commits into from
Jan 17, 2025

Conversation

magnusuMET
Copy link
Collaborator

Do a check if units are equivalent using cf_units, and not just str-equality, before raising an exception.

@magnusuMET magnusuMET requested a review from dulte January 17, 2025 11:51
dulte
dulte approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@dulte dulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution. Cf_units is not part of the requirements, so tests fail. Add it, and I think its ready for merging

@magnusuMET magnusuMET marked this pull request as ready for review January 17, 2025 12:56
@magnusuMET magnusuMET merged commit b7e0200 into main-dev Jan 17, 2025
4 checks passed
@magnusuMET magnusuMET deleted the eea_parquet_multi_units branch January 17, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulte dulte dulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnusuMET @dulte