Valleyfloor relaltitude filter #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heikoklein
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Nice functionality!
The ValleyFloorRelativeAltitudeFilter has many similarities to the RelativeAltitudeFilter which are not reflected by the implementation. A common private base-class might make the design clearer.
The topography-file should not kept open for longer than necessary. Considering the size of this data here (GTOPO30), the data should not kept permanently in memory.
heikoklein
approved these changes
Nov 6, 2024
heikoklein
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements a station filter that allows filtering based on the surrounding topography.
Related Issue
closes #47