Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow directory in valleyfloor filter #76

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

thorbjoernl
Copy link
Collaborator

Adds possibility to specify a directory with multiple nc files to the valley floor filter. Needed to be able to use the filter globally without very high memory usage.

Currently this uses a metadata.json file which specifies the latitude/longitude bounds of each indiviudal file.

Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for hard-coded default path, please remove.

src/pyaro/timeseries/Filter.py Outdated Show resolved Hide resolved
@thorbjoernl thorbjoernl merged commit 73eec6a into main Jan 6, 2025
3 checks passed
@thorbjoernl thorbjoernl deleted the allow-directory-in-valleyfloor-filter branch January 6, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants