Add support for PHP 8.4 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willReturnOnConsecutiveCalls was missing the call to the sort option, and raising an error due to being called more than 5 times. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- Adds 8.4 to PHP constraint - Bumps PHPUnit to 10.5 - Fixes a number of PHPUnit deprecations - Resolves an issue in the RoutesFilter when performing a regex against a FQCN. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- Primarily changing `?:` to `??` when the left side is testing against null - Adds some typehints where expectations are known - Adds `=== null` checks to validate a value is present - Indents a heredoc Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
First version fixing nullable argument handling. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Ensures deprecations will be resolved. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Should be true, because we already had this problem in other components. |
- Conflict with older versions of symfony 5 components - Bump vfsStream to latest Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
@gsteel All dependency issues resolved — there were some issues with older symfony components as well. |
|
Should these be merged, and #58 rebased, or would it be better to rebase this after that one is merged? |
|
Merged as-is #58 has a way to go, so the rebase can happen there 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds support for PHP 8.4.
To accomplish this, it also bumps PHPUnit to 10.5. Doing so uncovered a previously undetected issue with the RoutesFilter, whereby a class name used as filter was not properly escaped, causing the regexp to fail compilation; this has been fixed now.