Skip to content

Give research essays proper titles and clickable tags; compact agent actions - #2052

Merged
asim merged 1 commit into
mainfrom
codex/research-blog
Oct 8, 2026
Merged

asim merged 1 commit into
mainfrom
codex/research-blog

Conversation

@asim

@asim asim commented Oct 8, 2026

Copy link
Copy Markdown
Member

Evening readings saved the planner's title, which defaults to the broad topic without optional planning. Save the final writer's required title instead. Strengthen the writing prompt around explanation and synthesis and supply longer source excerpts.

Use Research for generated posts. Normalize legacy reading tags on load and recover their title from an existing leading H1 when the post has not been explicitly edited. Preserve privacy, publication state and dates. Render linked tags in blog lists and post pages, apply exact case-insensitive tag filters before pagination in HTML/JSON, retain filters during search/pagination, and use first-paragraph previews.

Flatten nested action rows on agent cards and use shared action spacing and icon alignment.

Validation: go test ./agent ./service/blog ./internal/app -short, formatting and diff checks. Tests cover title output, legacy metadata repair and edit preservation, exact/escaped tag links, owner-only private tag filtering. Browser fixtures at 390/1366px verified list/post tag links and equal top/bottom card spacing; screenshots inspected. Model editorial quality still needs evaluation on future generated readings.

@asim
asim merged commit 0c6fd22 into main Oct 8, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T08:31:28.749803Z 74c6e1b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74c6e1bd09

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread service/blog/blog.go
tag = strings.TrimSpace(tag)
if tag != "" {
badges = append(badges, fmt.Sprintf(`<span class="category">%s</span>`, tag))
badges = append(badges, fmt.Sprintf(`<a class="category" href="/blog?tag=%s">%s</a>`, url.QueryEscape(tag), stdhtml.EscapeString(tag)))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep private user-authored tags out of GET URLs

When a user opens a private draft/article—or a recipient opens a shared private article—this helper renders its author-entered tags as ?tag= links because PostHandler, privatePostItems, and previewPost call it without a visibility distinction. Clicking one records potentially sensitive tag text in browser history and the reverse proxy’s URI logs; private tags should remain non-links or use a POST-based filter rather than being copied into a query string.

AGENTS.md reference: AGENTS.md:L155-L161

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant