Repository navigation
Make agent card actions consistent text links - #2053
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e1642c8ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| b.WriteString(`<a class="link-button" href="` + e.Chat + `">Chat</a>`) | ||
| } | ||
| b.WriteString(`<a href="/agent/connect?id=` + html.EscapeString(e.ID) + `" aria-label="Connect to ` + html.EscapeString(e.Name) + `" title="Connect"><svg viewBox="0 0 24 24" width="18" height="18" fill="none" stroke="currentColor" stroke-width="1.5" aria-hidden="true"><path d="m9 15 6-6M8 16l-1 1a4 4 0 0 1-6-6l4-4a4 4 0 0 1 6 0m2 10a4 4 0 0 0 6 0l4-4a4 4 0 0 0-6-6l-1 1"/></svg></a>`) | ||
| b.WriteString(`<a class="link-button" href="/agent/connect?id=` + html.EscapeString(e.ID) + `">Connect</a>`) |
There was a problem hiding this comment.
When a screen-reader user navigates the roster through its links list, every row now exposes identical Chat and Connect accessible names because these replacements remove the previous agent-specific aria-label values. The surrounding .directory-row and .directory-list divs do not establish a labelled group, so users cannot tell which agent an action targets without leaving link navigation; keep the visible text while retaining labels such as Chat with <name> and Connect to <name>.
Useful? React with 👍 / 👎.
1 participant
Replace Chat and Connect icons with labelled links. Apply the shared link-button styling to Chat, Connect, Edit and Remove. Remove retains its POST form, CSRF token and confirmation, styled as a text link rather than a bordered button.
Validated agent/app tests, formatting and diff checks.