Support finding applicationinsights.json in current dir when using runtime attach #3990
+42
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
heyams,
jeanbisutti,
ramthi and
harsimar
as code owners
|
Spring Boot can also retrieve configuration files in the The Application Insights json file could also be retrieved from this subdirectory. |
jeanbisutti
reviewed
Jan 6, 2025
| try { | ||
| return Files.newInputStream(defaultFile.toPath()); | ||
| } catch (IOException e) { | ||
| throw new IllegalStateException( |
There was a problem hiding this comment.
| @@ -52,7 +55,10 @@ public static void attach() { | |||
| System.setProperty(RUNTIME_ATTACHED_ENABLED_PROPERTY, "true"); | |||
|
|
|||
| try { | |||
| Optional<String> jsonConfig = findJsonConfig(); | |||
| Optional<String> jsonConfig = findJsonConfigFromClasspath(); | |||
| if (!jsonConfig.isPresent()) { | |||
There was a problem hiding this comment.
Let's assume the user adds a JSON configuration file in src/main/resources and creates a Spring Boot executable JAR.
The user may want to use a configuration different from the default one in the classpath without creating a new JAR file.
It may be useful to check the configuration from the file system first.
jeanbisutti
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3989