Harden integer ranges in parallel BC compression - #744
Open
Roland Shum (ShumWengSang) wants to merge 4 commits into
Open
Roland Shum (ShumWengSang) wants to merge 4 commits into
Roland Shum (ShumWengSang) wants to merge 4 commits into
Conversation
Roland Shum (ShumWengSang)
marked this pull request as ready for review
September 30, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add integer-range validation to the existing parallel BC compression iterator:
uint64_t, calculate the rounded block extents and their product, then check the signed loop-count limit before narrowing.This follows the review suggestion to use wider intermediate arithmetic and cast back after checking the result. The dimension guard bounds the additions and product, as well as the later signed pixel-coordinate calculations.
This is a source-only, post-allocation arithmetic-hardening change. It does not move validation ahead of destination allocation, change the serial compression path, or change progress-callback behavior. Parallel inputs outside the helper's existing signed dimension/block-count range return an arithmetic-overflow error.
Validation
git diff --checkpass.Limits
The arithmetic model is not an end-to-end large-image reproduction. No valid file-input reachability or large-allocation mitigation is claimed. No new maintained test-suite regression is included; the local ordinary-image and arithmetic harnesses are validation evidence only.