Repository navigation
Python: Fix Ollama streaming finish reason for tool calls - #9763
Open
Dhruv Shaswat (Dhruv-Sh-git) wants to merge 1 commit into
Open
Dhruv Shaswat (Dhruv-Sh-git) wants to merge 1 commit into
Dhruv Shaswat (Dhruv-Sh-git) wants to merge 1 commit into
Conversation
Dhruv Shaswat (Dhruv-Sh-git)
deployed
to
github-app-auth
October 27, 2026 13:21 — with 
GitHub Actions
Active
GitHub Actions
Active
Dhruv Shaswat (Dhruv-Sh-git)
had a problem deploying
to
github-app-auth
October 27, 2026 13:21 — with
GitHub Actions
Error
GitHub Actions
Error
agent-framework-automation
Bot
added
the
python
github-actions
Bot
changed the title
Dhruv Shaswat (Dhruv-Sh-git)
deployed
to
github-app-auth
October 27, 2026 13:26 — with
GitHub Actions
Active
GitHub Actions
Active
Dhruv Shaswat (Dhruv-Sh-git)
deployed
to
github-app-auth
October 27, 2026 13:28 — with
GitHub Actions
Active
GitHub Actions
Active
Author
|
@microsoft-github-policy-service agree |
Dhruv Shaswat (Dhruv-Sh-git)
deployed
to
github-app-auth
October 27, 2026 13:31 — with
GitHub Actions
Active
GitHub Actions
Active
Dhruv Shaswat (Dhruv-Sh-git)
marked this pull request as ready for review
October 27, 2026 13:44
Dhruv Shaswat (Dhruv-Sh-git)
requested review from
SergeyMenshykh,
Tao Chen (TaoChenOSU),
Eduard van Valkenburg (eavanvalkenburg),
Giles Odigwe (giles17),
Jose Alvarez (jpalvarezl),
Evan Mattson (moonbox3),
Roger Barreto (rogerbarreto),
sophia-ramsey and
westey (westey-m)
as code owners
October 27, 2026 13:44
Dhruv Shaswat (Dhruv-Sh-git)
deployed
to
github-app-auth
October 27, 2026 13:44 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9676. This change keeps track of whether a tool call appeared during streaming and uses that information when parsing the final response. I also added a regression test for this case. Track tool calls across Ollama streaming chunks so the final response reports finish_reason='tool_calls' instead of 'stop'. Add a regression test covering a tool call in a non-terminal chunk followed by a terminal chunk without tool calls. This contribution was developed with AI assistance. The changes and tests were reviewed and validated locally.