use rootdir instead of chroot for image release file #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwize1
approved these changes
Dec 20, 2024
cwize1
reviewed
Dec 20, 2024
| @@ -21,23 +20,19 @@ func TestAddCustomizerRelease(t *testing.T) { | |||
| } | |||
|
|
|||
| proposedDir := filepath.Join(tmpDir, "TestAddCustomizerRelease") | |||
There was a problem hiding this comment.
Might be good to rename proposedDir to something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function to add release file, we pass in chroot and find its root dir, which consequently requires us to initialize a chroot in its test. Since the only purpose of passing in chroot is to get its root dir, we can simplify the function (and test) by passing in the root dir directly.
Checklist