Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json schema generation tool #59

Merged
merged 13 commits into from
Jan 8, 2025
Merged

Add json schema generation tool #59

merged 13 commits into from
Jan 8, 2025
+121 −2

Conversation

romoh
Copy link
Contributor

@romoh romoh commented Jan 1, 2025 •
edited
Loading

Add a cli that generates image customizer API json schema.
The generated schema file can be leveraged by other tools for API dependency and config validation.

Here's an example using it in VSCode for syntax validation:
image

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • Code conforms to style guidelines

@romoh romoh marked this pull request as ready for review January 2, 2025 23:35
@romoh romoh requested a review from a team as a code owner January 2, 2025 23:35
cwize1
cwize1 requested changes Jan 6, 2025
View reviewed changes
toolkit/tools/imagecustomizerschemacli/go.mod Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/Makefile Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/Makefile Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerapi/partitionsize.go Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/main.go Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/Makefile Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/Makefile Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/main.go Outdated Show resolved Hide resolved
@romoh romoh force-pushed the user/romoh/schema branch 2 times, most recently from 5cb34c3 to 6249124 Compare January 8, 2025 01:50
cwize1
cwize1 requested changes Jan 8, 2025
View reviewed changes
toolkit/tools/imagecustomizerapi/disksize.go Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerapi/partitionsize.go Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerapi/partitionsize.go Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/Makefile Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/main.go Outdated Show resolved Hide resolved
toolkit/.gitignore Outdated Show resolved Hide resolved
toolkit/tools/go.mod Outdated Show resolved Hide resolved
toolkit/tools/go.mod Outdated Show resolved Hide resolved
toolkit/tools/imagecustomizerschemacli/main.go Outdated Show resolved Hide resolved
romoh added 11 commits January 8, 2025 11:46
@romoh
jsonschema cli
7f725de 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
updates
62df048 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
rebase
a65b248 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
update
ca23e85 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
remove schema file for now
0fdb68e 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
updatE
cbbed64 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
feedback
31cb14e 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
rebase
20e348b 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
feedback
f2ce3b4 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
restore .gitignore
7cde1d7 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh
fix
f4738a7 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh romoh force-pushed the user/romoh/schema branch from 6249124 to f4738a7 Compare January 8, 2025 20:21
@romoh
remove go.sum
89fbcbc 
Signed-off-by: Roaa Sakr <[email protected]>
cwize1
cwize1 requested changes Jan 8, 2025
View reviewed changes
toolkit/tools/go.mod Outdated Show resolved Hide resolved
@romoh
take2
9f8cc8d 
Signed-off-by: Roaa Sakr <[email protected]>
@romoh romoh requested a review from cwize1 January 8, 2025 20:34
@romoh romoh merged commit e625439 into main Jan 8, 2025
7 checks passed
@romoh romoh deleted the user/romoh/schema branch January 8, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liulanze liulanze liulanze left review comments

@cwize1 cwize1 cwize1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romoh @cwize1 @liulanze