Native ETag Support #675
Open
Native ETag Support #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamdaankhalid
force-pushed
the
hkhalid/etag-impl
branch
4 times, most recently
from
77487f1 to
d564238
Compare
hamdaankhalid
force-pushed
the
hkhalid/etag-impl
branch
from
b126e5e to
da48417
Compare
TedHartMS
reviewed
Oct 1, 2024
hamdaankhalid
commented
Dec 28, 2024
| { | ||
| public struct EtagOffsetManagementContext | ||
| { | ||
| // default values for when no Etag exists on a record |
There was a problem hiding this comment.
misplaced comments
hamdaankhalid
commented
Jan 6, 2025
| @@ -98,6 +98,8 @@ private bool NetworkEXEC() | |||
| private bool NetworkSKIP(RespCommand cmd) | |||
| { | |||
| // Retrieve the meta-data for the command to do basic sanity checking for command arguments | |||
| // Normalize will turn internal "not-real commands" such as SETEXNX, and SETEXXX to the command info parent | |||
| cmd = cmd.Normalize(); | |||
There was a problem hiding this comment.
this fixes the issue that wouldnt let XX, NX, and as a result SETIFMATCH and SET + WITHETAG work inside of multi exec
darrenge
requested changes
Jan 7, 2025
hamdaankhalid
commented
Jan 8, 2025
| /// <summary> | ||
| /// When ETag is set this returns 1 else 0. Used for branchless programming | ||
| /// </summary> | ||
| public int HasETagMultiplier => (int)((word & kETagBitMask) >> kEtagBitOffset); |
There was a problem hiding this comment.
TODO remove this
badrishc
reviewed
Jan 8, 2025
| /// GETWITHETAG key | ||
| /// Given a key get the value and ETag | ||
| /// </summary> | ||
| private bool NetworkGETWITHETAG<TGarnetApi>(ref TGarnetApi storageApi) |
There was a problem hiding this comment.
Move all the added etag commands to their own file such as BasicETagCommands.cs
badrishc
reviewed
Jan 8, 2025
| @@ -36,6 +36,7 @@ static void CopyTo(ref SpanByte src, ref SpanByteAndMemory dst, MemoryPool<byte> | |||
|
|
|||
| void CopyRespTo(ref SpanByte src, ref SpanByteAndMemory dst, int start = 0, int end = -1) | |||
| { | |||
| // src length of the value indicating no end is supplied defaults to lengthWithoutMetadata, else it chooses the bigger of 0 or (end - start) | |||
There was a problem hiding this comment.
fix this comment, i do not parse it.
badrishc
reviewed
Jan 8, 2025
| } | ||
| } | ||
|
|
||
| static void RespWriteEtagValArray(long etag, ref ReadOnlySpan<byte> value, ref byte* curr, byte* end, bool writeDirect) |
There was a problem hiding this comment.
this, the previous, etc. should move to RespWriteUtils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native ETag Support
Garnet provides support for ETags on raw strings. You can associate any string-based key-value pair inserted into Garnet with an automatically updated ETag.
Compatibility with non-ETag commands and the behavior of data inserted with ETags are detailed in the markdown for garnet specific commands. Please read the markdown file for API contracts, and compatibility.
HLD:
RecordInfofor a record indicated whether or not a record contains an ETag. This bit on the record info is used to indicate that the first 8 bytes of the payload of the record include a long data type that represents the eTag associated with the value that is present after the first 8 bytes.Reads don't modify the eTag, but any RMW operations do. Blind Upsert (SET) will remove the eTag unless sent with the RETAINETAG flag.
ETags are incremented on each update, and the user can use them to handle things such as caching and Optimistic concurrency control.