Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary wording from codebase #26

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Remove unnecessary wording from codebase #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3689e8f
Restore required words
AlonsoGuevara Apr 3, 2024
032b9bd
Merge branch 'main' into task/review_wording
AlonsoGuevara Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ scatterplot
SITREP
megapipeline
columnwise
janky
docstore
datasource
devcontainers
Expand All @@ -131,28 +130,6 @@ MSRC
Arrary

# Prompt Inputs
VOLKIMIR
VLODIMIR
VOLODYMYR
VOLADIMIR
VOLODYMYR
VOLDEMIR
VOLDEMIR
VOLYNMYR
VOLYNMYR
VOLYN
ZELENS
ZELENSKY
ZELENSKI
ZELENSKIY
ZELENSKYI
ZELENSKII
ROSIYA
ROSSIA
ROSIYA
ROSIJA
ROSIA
OLEKSANDROVYCH
Siamak
Namazi
Emad
Expand All @@ -163,7 +140,6 @@ Tahbaz
abila
abilas
payus
derp
POKRALLY
dulce

Expand Down
2 changes: 1 addition & 1 deletion python/graphrag/graphrag/index/workflows/v1/create_final_communities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def build_steps(


create_community_title_wf = [
# janky way of string concat "Community " + id
# Hack to string concat "Community " + id
{
"verb": "fill",
"args": {
Expand Down
6 changes: 3 additions & 3 deletions python/graphrag/tests/unit/indexing/cache/test_file_pipeline_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ async def test_child_cache(self):
await self.cache.set("test1", "test1")
assert os.path.exists(f"{TEMP_DIR}/test1")

child = self.cache.child("derp")
assert os.path.exists(f"{TEMP_DIR}/derp")
child = self.cache.child("test")
assert os.path.exists(f"{TEMP_DIR}/test")

await child.set("test2", "test2")
assert os.path.exists(f"{TEMP_DIR}/derp/test2")
assert os.path.exists(f"{TEMP_DIR}/test/test2")

await self.cache.set("test1", "test1")
await self.cache.delete("test1")
Expand Down
16 changes: 8 additions & 8 deletions python/graphrag/tests/unit/indexing/default_config/test_default_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ def test_text_input_returns_correct_config(self):
"GRAPHRAG_ENTITY_EXTRACTION_MAX_GLEANINGS": "112",
"GRAPHRAG_SUMMARIZE_DESCRIPTIONS_MAX_LENGTH": "12345",
"GRAPHRAG_COMMUNITY_REPORT_MAX_LENGTH": "23456",
"GRAPHRAG_CLAIM_EXTRACTION_DESCRIPTION": "derp 123",
"GRAPHRAG_CLAIM_EXTRACTION_DESCRIPTION": "test 123",
"GRAPHRAG_MAX_CLUSTER_SIZE": "123",
"GRAPHRAG_UMAP_ENABLED": "true",
"GRAPHRAG_ENCODING_MODEL": "derp123",
"GRAPHRAG_ENCODING_MODEL": "test123",
"GRAPHRAG_SKIP_WORKFLOWS": "a,b,c",
},
clear=True,
Expand All @@ -103,7 +103,7 @@ def test_create_parameters_from_env_vars(self) -> None:
assert parameters.llm["api_key"] == "test"
assert parameters.llm["model"] == "test-llm"
assert parameters.parallelization["num_threads"] == 987
assert parameters.encoding_model == "derp123"
assert parameters.encoding_model == "test123"
assert parameters.skip_workflows == ["a", "b", "c"]
assert parameters.storage.type == PipelineStorageType.blob
assert parameters.storage.connection_string == "test_cs"
Expand All @@ -128,7 +128,7 @@ def test_create_parameters_from_env_vars(self) -> None:
assert parameters.entity_extraction.max_gleanings == 112
assert parameters.summarize_descriptions.max_length == 12345
assert parameters.community_reports.max_length == 23456
assert parameters.claim_extraction.description == "derp 123"
assert parameters.claim_extraction.description == "test 123"
assert parameters.cluster_graph.max_cluster_size == 123
assert parameters.umap.enabled

Expand Down Expand Up @@ -179,19 +179,19 @@ def test_create_parameters(self) -> None:
community_reports=CommunityReportsConfigModel(
max_length=23456,
),
claim_extraction=ClaimExtractionConfigModel(description="derp 123"),
claim_extraction=ClaimExtractionConfigModel(description="test 123"),
cluster_graph=ClusterGraphConfigModel(
max_cluster_size=123,
),
umap=UmapConfigModel(enabled=True),
encoding_model="derp123",
encoding_model="test123",
skip_workflows=["a", "b", "c"],
),
".",
)
assert parameters.llm["api_key"] == "test"
assert parameters.llm["model"] == "test-llm"
assert parameters.encoding_model == "derp123"
assert parameters.encoding_model == "test123"
assert parameters.skip_workflows == ["a", "b", "c"]
assert parameters.storage.type == PipelineStorageType.blob
assert parameters.storage.connection_string == "test_cs"
Expand All @@ -217,7 +217,7 @@ def test_create_parameters(self) -> None:
assert parameters.entity_extraction.max_gleanings == 112
assert parameters.summarize_descriptions.max_length == 12345
assert parameters.community_reports.max_length == 23456
assert parameters.claim_extraction.description == "derp 123"
assert parameters.claim_extraction.description == "test 123"
assert parameters.cluster_graph.max_cluster_size == 123
assert parameters.umap.enabled

Expand Down
Loading