Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Remove cgroupv1 kernel parameters for kata #203

Closed
wants to merge 1 commit into from

Conversation

miz060
Copy link
Member

@miz060 miz060 commented Jun 17, 2024

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

Remove cgroupv1 kernel parameters for kata

Test Methodology

Conformance test result: 585964

@miz060 miz060 requested review from a team as code owners June 17, 2024 17:32
Remove cgroupv1 kernel parameters for kata

Signed-off-by: Mitch Zhu <[email protected]>
@miz060 miz060 force-pushed the mitchzhu/main-cgroupv2 branch from 460b785 to 60aa8dd Compare June 17, 2024 17:34
@miz060 miz060 added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Jun 17, 2024
@ms-mahuber
Copy link

Please do not merge :) But thanks. Please take a look at the code in: https://github.com/microsoft/kata-containers/tree/mahuber/uvm-spec-build

I believe this does match your needs?

@ms-mahuber
Copy link

Please do not merge :) But thanks. Please take a look at the code in: https://github.com/microsoft/kata-containers/tree/mahuber/uvm-spec-build

I believe this does match your needs?

I think it matches your needs but we will also want to set the following, conditionally: DEFSANDBOXCGROUPONLY=true

@sprt
Copy link
Collaborator

sprt commented Jun 17, 2024

Why is this needed?

@miz060
Copy link
Member Author

miz060 commented Jun 17, 2024

Please do not merge :) But thanks. Please take a look at the code in: https://github.com/microsoft/kata-containers/tree/mahuber/uvm-spec-build

I believe this does match your needs?

Yep this should do. Closing PR now...

@miz060
Copy link
Member Author

miz060 commented Jun 17, 2024

Why is this needed?

This is to support cgroupv2 Mariner 3 Kata image. But this code change address the same issue:
https://github.com/microsoft/kata-containers/tree/mahuber/uvm-spec-build

I'll close this PR now.

@miz060 miz060 closed this Jun 17, 2024
@miz060 miz060 deleted the mitchzhu/main-cgroupv2 branch July 10, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants