runtime: skip logging some of the dial errors #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprt
approved these changes
Nov 15, 2024
With full debug logging enabled there might be around 1,500 redials so log just ~15 of these redials to avoid flooding the log. Signed-off-by: Dan Mihai <[email protected]>
danmihai1
force-pushed
the
danmihai1/dial-errors
branch
from
5c6d793 to
663a003
Compare
|
Hoping to get feedback on upstream PR 10607. |
|
Merged as upstream commit 531a291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With full debug logging enabled there might be around 1,500 redials so skip logging some of these failures to avoid flooding the log.