Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Fix make test for virtcontainers. #257

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Sumynwa
Copy link

@Sumynwa Sumynwa commented Dec 2, 2024

This commit fixes make test for virtcontainers. It fixes:
a. hypervisor_test::TestAssetPath by adding igvm asset path.
b. clh_test::TestCreateVM by setting testData expectError to false for ConfidentialGuest test config.
This is needed because we have allowed noneProtection for test purposes for Confidential configuration.

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

Fix make test for src/runtime/virtcontainers.

Test Methodology

Local run tests:
go test --run TestAssetPath
go test --run TestClhCreateVm

@Sumynwa Sumynwa requested review from a team as code owners December 2, 2024 17:54
This commit fixes make test for virtcontainers. It fixes:
a. hypervisor_test::TestAssetPath by adding igvm asset path.
b. clh_test::TestCreateVM by setting testData expectError to
false for ConfidentialGuest test config. This is needed because
we have allowed noneProtection for test purposes for Confidential
configuration.

Signed-off-by: Sumedh Alok Sharma <[email protected]>
@Sumynwa Sumynwa force-pushed the sumsharma/fix_runtime_make_test branch from 24e4c2b to 8fd0c5e Compare December 2, 2024 18:00
@sprt
Copy link
Collaborator

sprt commented Dec 2, 2024

Could you also set that test (and similar) as required in the GH UI?

@Sumynwa Sumynwa merged commit c4ff507 into msft-main Dec 3, 2024
46 of 55 checks passed
@Sumynwa Sumynwa deleted the sumsharma/fix_runtime_make_test branch December 3, 2024 05:40
@Sumynwa
Copy link
Author

Sumynwa commented Dec 3, 2024

Could you also set that test (and similar) as required in the GH UI?

I don't have permissions to see the settings. @ms-mahuber can you help here. Below tests can be marked as Required:
build-checks (runtime, make test)
build-checks (runtime, sudo -E PATH="$PATH" make test)

@sprt sprt added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants